Web bundle concept #82
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
=======================================
Coverage 95.83% 95.83%
=======================================
Files 4 4
Lines 840 840
Branches 124 124
=======================================
Hits 805 805
Misses 33 33
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
In general, this is the right approach in the sense that this setup will create the correct build artefacts.
However, it has been a long standing problem that we used 30 copies of a slightly varying build setup across all repositories. Initially, the idea behind this was that each plugin could be maintained by a different person, so they should all have complete freedom over their setup. However, this turned out to be different in reality. Now, a handful of people all maintain several plugins each, and they communicate a lot so it's sort of like a small, integrated team. In such a world, it's rather annoying to have to remember and sync up changes between many repos. (Example: There were many PQs necessary to change the encoding option in TS config files.)
Therefore, ideally, we would want to extract the build config from the core repo and put it in a central place. All plugins could then rely on this shared setup, which would help us prevent the replication introduced in this PQ many times across many repos. We first need to work on fromdeno/deno2node#40 and then create a new repo with a generic build script.
Since we still want to allow customisation of this setup in specific repos, we may want to export the build steps as functions from the common build script.
|
You can already use deno2node API to write a shared build script. I'm happy to help :) TypeScript expects |
|
We want to share the config between projects, and resolve files via script args |
|
The API doesn't even require const ctx = new Context({ compilerOptions });
ctx.project.addSourceFilesAtPaths(...); |
deno.jsonc
Outdated
| @@ -7,12 +7,14 @@ | |||
| "dev": "deno fmt && deno lint && deno task test && deno task check", | |||
| "clean": "git clean -fX out test/cov_profile test/coverage coverage.lcov", | |||
| "coverage": "deno task clean && deno task test --coverage=./test/cov_profile && deno coverage --lcov --output=./coverage.lcov ./test/cov_profile", | |||
| "report": "genhtml ./coverage.lcov --output-directory ./test/coverage/ && echo 'Point your browser to test/coverage/index.html to see the test coverage report.'" | |||
| "report": "genhtml ./coverage.lcov --output-directory ./test/coverage/ && echo 'Point your browser to test/coverage/index.html to see the test coverage report.'", | |||
| "bundle-web": "mkdir -p out deno_cache && cd bundling && DENO_DIR=$PWD/../deno_cache deno run --unstable --quiet --allow-net --allow-read --allow-env=DENO_DIR,XDG_CACHE_HOME,HOME,DENO_AUTH_TOKENS --allow-write=../out,$PWD/../deno_cache bundle-web.ts dev ../src/mod.ts", | |||
There was a problem hiding this comment.
Consider setting cache root within grammY's script, and re-using it here to avoid duplication:
| "bundle-web": "mkdir -p out deno_cache && cd bundling && DENO_DIR=$PWD/../deno_cache deno run --unstable --quiet --allow-net --allow-read --allow-env=DENO_DIR,XDG_CACHE_HOME,HOME,DENO_AUTH_TOKENS --allow-write=../out,$PWD/../deno_cache bundle-web.ts dev ../src/mod.ts", | |
| "bundle-web": "mkdir -p out deno_cache && cd bundling && deno run --unstable --quiet --allow-net --allow-read=.. --allow-write=../out,../deno_cache https://raw.githubusercontent.com/grammyjs/grammY/v1.17.2/bundling/bundle-web.ts dev ../src/mod.ts", |
Co-authored-by: Wojciech Pawlik <woj.pawlik@gmail.com>
|
I don't know how to prevent bundling entire grammY in. Isn't the Node build of |
|
We are going to:
I don't really know yet when this will happen, but once it does, it will supersede this. |
|
If someone is looking for a way to solve the problem of running the conversations plugin in the Vercel Edge environment, it is: {
"dependencies": {
"@grammyjs/conversations": "^1.1.2"
},
"overrides": {
"o-son": "npm:@ponomarevlad/o-son@1.0.1-web.1"
}
} |
Is this the right direction, or need something different ? 🌚